Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC MILO Release 0.2443 #864

Merged
merged 42 commits into from
Oct 22, 2024
Merged

DC MILO Release 0.2443 #864

merged 42 commits into from
Oct 22, 2024

Conversation

joaquinrivero
Copy link
Collaborator

Release Notes: DC Milo 0.2443

joaquinrivero and others added 30 commits October 9, 2024 10:25
* 'MWPW-160119' of github.com:adobecom/dc:
  svg loading programatically
  MWPW-158010

# Conflicts:
#	acrobat/blocks/verb-widget/icons.js
MWPW-160119: Optimize Verb Widget Performance
resolves MWPW-160132
MWPW-160618, MWPW-160613, MWPW-160606
@joaquinrivero joaquinrivero added this to the 0.2443 milestone Oct 22, 2024
Copy link

aem-code-sync bot commented Oct 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.65591% with 71 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (111d0d7) to head (45d8cd5).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 3.38% 57 Missing ⚠️
acrobat/blocks/verb-widget/icons.js 48.14% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   88.57%   85.05%   -3.53%     
==========================================
  Files          51       48       -3     
  Lines        7819     6094    -1725     
==========================================
- Hits         6926     5183    -1743     
- Misses        893      911      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/order> reported by reviewdog 🐶
../../acrobat/scripts/utils import should occur after import of @esm-bundle/chai

import { setLibs, getLibs } from '../../acrobat/scripts/utils';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.

import { setLibs, getLibs } from '../../acrobat/scripts/utils';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"

import { setLibs, getLibs } from '../../acrobat/scripts/utils';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.

import * as sinon from 'sinon';

@joaquinrivero joaquinrivero merged commit 20b5b9d into main Oct 22, 2024
329 of 360 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants